[ci-coach] Fix prettier formatting in eslint-factory test file

CI Optimization Coach · pull request · closed

Filter2mode:review mode:live
All recorded Export JSON
github-actions[bot]

published Aug 25, 2026, 1:40 PM · updated Aug 25, 2026, 2:08 PM

CI Optimization Proposal (Pre-flight Repair)

Summary

Pre-flight validation showed make lint failing with exit code 2 (fmt-check-cjs step). Root cause: eslint-factory/src/rules/require-decodeuricomponent-try-catch.test.ts had a valid array formatted across multiple lines that Prettier expects collapsed onto a single line given the line-length config.

Fix

  • Type: Pre-flight repair (lint failure)
  • Impact: Unblocks make lint / CI lint job for every contributor and PR in this repo
  • Risk: None — whitespace-only change in a test file, no logic altered
  • Changes: Ran prettier --write on the file; reformatted the valid array literal
  • Rationale: make lint runs fmt-check-cjs which requires all .ts/.cjs/.json files under eslint-factory to match Prettier formatting. This file drifted out of sync (likely edited without running prettier locally).

Validation Results

  • prettier --check on eslint-factory now passes (was failing before the fix).
  • make build / make test-unit could not be run to completion in this sandbox due to an unrelated Go toolchain download restriction (go.mod requires go >=1.26.6, network to proxy.golang.org is blocked in this environment) — this is a pre-existing sandbox limitation, not caused by this change, and the pre-flight snapshot already recorded build/test-unit as passing (ok: true) prior to this fix.

Metrics Baseline

  • Pre-flight validation status before fix: lint step exit_code=2, ok=false; all other steps ok.
  • This is a single-file, whitespace-only diff with no functional risk.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • proxy.golang.org
  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "registry.npmjs.org"

See Network Configuration for more information.

Generated by CI Optimization Coach · copilot · auto · 32.6 AIC · ⌖ 11.7 AIC · ⊞ 16.4K ·

  • expires on Aug 27, 2026, 5:40 AM UTC-08:00